[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/scumm actor.cpp,1.148,1.149 debugger.cpp,1.71,1.72 gfx.cpp,2.181,2.182 script_v5.cpp,1.143,1.144 scumm.h,1.279,1.280 scummvm.cpp,2.317,2.318

[Max Horn]

Am Mittwoch, 06.08.03 um 13:37 Uhr schrieb Travis Howell:

> Max Horn wrote:
>> Am Mittwoch, 06.08.03 um 11:30 Uhr schrieb Travis Howell:
>>
>>> Update of /cvsroot/scummvm/scummvm/scumm
>>> In directory sc8-pr-cvs1:/tmp/cvs-serv13246/scumm
>>>
>>> Modified Files:
>>> actor.cpp debugger.cpp gfx.cpp script_v5.cpp scumm.h
>>> scummvm.cpp
>>> Log Message:
>>>
>>> Add GF_LOOM feature flag for loom games to reduce checks.
>>> Will make it easier to add loom fm towns target in future.
>>>
>> Uhm... I am not too happy about this change, and the GF_INDY3 change.
>> Feature flags should indicate *features*. Being Loom or Indy3 isn't a
>> feature. I was considering in the past if one could merge the various
>> GIDs into a single one and then distinguish the various Indy3/Loom
>> versionsbased on some feature flags - either existing feature flags,
>> or new ones which describe more precisely the features distinguishing
>> Indy3/Loom from other games.
>
> The feature flag is already used to indicate game types in simon, the
> changes make game checks simpler and easier to read. Using the  GF_* 
> feature
> flag just seemed like best way to do it. Merging the indy3/indy3towns
> targets and adding fm towns option is a bad idea and would just lead to
> confusion, since fm towns version of zak will always be a separate 
> target...

Uhm, I am talking about merging the GIDs. I still stand to the point 
that using the GF flags this way is bad. The fact that simon does it 
doesn't affect my opinion at all - Simon code does a lot of horrible 
things, so why should it be a standard for anything?

Anyway, by using a single GID for Indy3, the code is at least as clean 
than using GD_INDY3.


Max