[Scummvm-devel] Re: Port status?

Max Horn max at quendi.de
Wed Jul 23 16:04:02 CEST 2003


Am Donnerstag, 24.07.03 um 00:48 Uhr schrieb Ruediger Hanke:

> Sorry, think I forgot to CC the last mail to the list.
>
>> We're going to hard-freeze (port & bugfixes -only-) tommorow morning, 
>> so
>> can I please have all port maintainers confirm their ports are (or 
>> will be
>> within a few days) ready to build release binaries?
>
> Well, I'm done now. The MorphOS port should be ready for a release.
> At least I think so. I've tested several games, played through a few 
> screens
> and everything works.
>
Good.

> Folks, you really should do something about your resource cleanup ...
> I know, I think I mentioned this before and I think I got the answer 
> that
> modern OSes will clean up resources automagically so there's no need
> to do this but ...
Indeed they do. And in addition, of course you get a chance to clean up 
inside of OSystem::quit...

>
> For me it's vital that at least audio resources are properly closed. 
> The
> MIDI driver never got destructed, so eventually I inserted a hack to 
> delete
> it myself in the end. Now it seems to be cleaned up, and that was the
> reason for a crash I had (freed twice).
>

This is no problem with scumm + SDL backend. There are no calls to 
OSystem::quit() in it left. simon/sky might be different.

So, if the MIDI driver is not closed for you when playing Scumm, I am 
fairly certain it's a problem with your backend, not ScummVM. Are you 
even generating quit events (EVENT_QUIT) ?


> So now that I removed the hack suddenly I had the problem with Simon
> that notes sounded endlessly after quitting and no other programs could
> playback any MIDI until a reset because there it's still not freed 
> (it's
> supposed to be deleted with the SimonEngine, but SimonEngine object is
> never deleted) ...

Seems the simon frontend still calls OSystem::quit().

BTW, I don't quite understand, why can't you clean up the MIDI driver 
in OSystem::quit() ?

>
> Anyway, I solved it now. Feel free not to change anything or it 
> probably
> breaks my port again. But ideally I'd prefer the program to close 
> everything
> by itself as it would save (me) some debugging time.
>
It's up to the people maintaining the sky/simon frontends to fix them. 
*after* the 0.5.0 release (or after we branch, I am working on that 
now).


Max





More information about the Scummvm-devel mailing list