[Scummvm-devel] CVS: "added extra flag to mixer so we don't use free() on new'd pointers"

Marcus Comstedt marcus at mc.pp.se
Sat Oct 25 04:40:51 CEST 2003


Joost Peters <j at 7fc1.org> writes:

> It's not simply a matter of changing the new to malloc() as the same
> function that allocates the memory passed to the mixer is also used all over
> the place in Queen (and they DELETE memory returned from it), so I can
> either change all those references to free(), or add this to the mixer. Take
> a pick.

Maybe the real question is why the mixer frees something it didn't
allocate in the first place.  That's a layering violation, and should
never happen (regardless of flags) IMNSHO.


  // Marcus






More information about the Scummvm-devel mailing list