[Scummvm-devel] Re: New DEFAULT_SAVE_PATH in 0.7.0 ?
Max Horn
max at quendi.de
Sat Dec 18 14:00:01 CET 2004
Am 18.12.2004 um 22:44 schrieb Jonathan Gray:
> On Sat, Dec 18, 2004 at 05:36:57PM +0100, Max Horn wrote:
[...]
>> Hum, I am not sure if we really want to have that feature in 0.7.0,
>> it's a bit hasty to add it so shortly before the release and all.
>>
>> For example, the code you inserted to handle the save dir isn't quite
>> safe: it doesn't check that DEFAULT_SAVE_PATH is actually pointing to
>> a
>> writable directory.
>
> In this case they just won't be able to save, but I can't imagine this
> ever really happening in practice.
>
>>
>> Also, this is a behavior change: anybody who so far used scummvm w/o
>> an
>> explicitly set savepath won't be able to load their savegames anymore.
>> Hence, at the very least this new feature should be documented in the
>> README before we put it in a full blown release!
>
> Isn't NEWS more appropriate? I guess I could do both.
Yes, please.
> I'd rather not
> see this go another 6 months. Many people (including tore) have been
> asking for this and it is consitent with the behaviour of other
> programs.
Understood. Of course if the change had been implemented back then as
opposed to one week before a release, that would have been far
preferable :-). Ah well, I guess this particular feature should be
"harmless". At worst we should get a ton of complaints/SRs rolling in
:-)
Cheers,
Max
More information about the Scummvm-devel
mailing list