[Scummvm-devel] Simon changes

[Max Horn]

Replying to myself.... :-)

Am 31.07.2004 um 10:58 schrieb Max Horn:

>
> Am 30.07.2004 um 11:00 schrieb Travis Howell:
>
>> Update of /cvsroot/scummvm/scummvm/simon
>> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29916/simon
>>
>> Modified Files:
>> 	intern.h simon.cpp sound.cpp
>> Added Files:
>> 	simon-md5.h
>> Log Message:
>>
>> Reduce simon 1/2 targets
>> Add auto detection
>>
>
> [...]
>

> Auto-detection is fine, but lack of any upgrade strategy seems like a 
> bad idea to me. So anybody using the simon2mac, simon2win or simon1win 
> targets in their config file now has bad config entries. Worse, 
> without manually editing the config file, there is no way for them to 
> fix it; so one has to re-add those entries. Of course that's possible, 
> but it'd be sooo much nice if a smooth transition was enabled.
>
> At the very least, instead of just exiting, print a message which 
> tells people to manually update their config file. That also means 
> telling people which targets they should use instead now.
>
> Or still allow the old target names, but print a "deprecated" message.
>
> Or automagically update those targets: if for example a "simon2mac" 
> target is loaded (i.e. a target with that gameid), automatically 
> update its gameid value to whatever now is the appropriate gameid 
> (actually, I have no idea what that is...
>
>
Actually, thinking about it, as a developer I very much prefer the 
second variant (accept old targets; maybe print a "deprecated" message, 
though one can argue whether that is really useful), at least for the 
next few months: I am right now trying to track down some of the simon 
regressions in HEAD CVS, which aren't present in 0.6.1; right now I 
have to either switch back and forth between two config files, or 
duplicate my simon config entries, once in the "old" style, once in the 
new one. Which isn't so nice :-/

As for those regressions: I converted my "simon2win" target to use 
"simon2talkie" as gameid (with simon2dos it'll crash). Music/SFX don't 
work anymore, I get this error:

Trying to start game 'Simon the Sorcerer 2 Talkie'
bd85a8b5135592ada9cbeae49160f1d3  GSPTR30
Match found in database: target simon2talkie, language English (US), 
platform Windows
WARNING: Expected 'FORM' tag but found 'MTh' instead!!


And for simon1win:

Trying to start game 'Simon the Sorcerer 1 Talkie'
d22302abf44219f95d50f2faa807dd1a  GAMEPC
Match found in database: target simon1talkie, language English (US), 
platform Windows
WARNING: Can't open effects file EFFECTS.VOC!
WARNING: Expected MThd or GMD header but found 'MTh' instead!
Error reading track!


Looks like some more changes are needed :-)

Max