[Scummvm-devel] The "Sam and Max inventory hack"

Max Horn max at quendi.de
Mon Mar 1 08:05:05 CET 2004


Am 01.03.2004 um 15:46 schrieb <Torbjorn.E.Andersson at tietoenator.com>:

> This is script-52, the inventory script that Sam & Max invokes when  
> calling
> setOwnerOf():
>
[...]
>
> This can't work, because we invoke the inventory script by calling
> runInventoryScript(0), so localvar0 is 0 instead of the object that
> the script is called for. I think.
>
> Changing this to runInventoryScript(obj) allows me to remove the hack,
> and ScummVM no longer crashes on the savegame I attached to bug  
> #907113,
> http://sourceforge.net/tracker/index.php? 
> func=detail&aid=907113&group_id=37116&atid=418820
>
> But I don't know if this would break other things.
>

Well it should be OK to apply it to HEAD. Although maybe somebody could  
verify the V6-V8 disassembly of setOwnerOf. If we find out the fix  
matches the code there, it could be applied to the 0.6.0 branch, too...


Cheers,

Max





More information about the Scummvm-devel mailing list