[Scummvm-devel] The "Sam and Max inventory hack"

Max Horn max at quendi.de
Mon Mar 1 08:12:12 CET 2004


Am 01.03.2004 um 16:46 schrieb James 'Ender' Brown:

>> This can't work, because we invoke the inventory script by calling
>> runInventoryScript(0), so localvar0 is 0 instead of the object that
>> the script is called for. I think.
>>
>> Changing this to runInventoryScript(obj) allows me to remove the hack,
>> and ScummVM no longer crashes on the savegame I attached to bug  
>> #907113,
>> http://sourceforge.net/tracker/index.php? 
>> func=detail&aid=907113&group_id=37116&atid=418820
>>
>> But I don't know if this would break other things.
>
> It sounds reasonable to me. Put it in HEAD and we'll test - I mean, I
> can't imagine it breaking anything as I doubt anything would depend on
> localVar0 being 0 :)
>
Well, actually things might - the fix should be restricted to V6+ games  
only, as for older games it's definitely a 0 there...


Cheers,

Max





More information about the Scummvm-devel mailing list