[Scummvm-devel] Features and graphics modes

[Marcus Comstedt]

Max Horn <max at quendi.de> writes:

> Well, the "default" scaler name is a special purpose name. It's not
> necessarily the case that the backend actually supports a scaler with
> that name. The SDL backend, for example, doesn't.
>
> The way this is currently done is bad because it is based on the
> assumption that "2x" is the default scaler. However, the alternative
> you suggest is likewise bad, because it is based on the assumption
> that the first listed scaler is the default scaler.
>
> Hence my suggestion to define a scaler *mode* (not name) which simply
> tells the backend to switch to whatever it considers "default". Yet
> another alternative would be to add a method getDefaultGraphicsMode()
> to the backends. Both mean adding to the OSystem API, but both also
> work w/o any additional assumptions about the backend and its graphics
> modes.

Wrong.  Claiming a special mode id makes the assumption that this id
can not be used by a normal mode.  Depending on how the backend
selects its mode identifiers, this may not be a valid assumption.
The getDefaultGraphicsMode() function is probably the best solution.


  // Marcus