[Scummvm-devel] Re: [Scummvm-cvs-logs] CVS: scummvm/saga music.cpp,1.34,1.35

Eugene Sandulenko sev at interhack.net
Sun Nov 21 13:10:04 CET 2004


Torbjörn Andersson writes:
 > Update of /cvsroot/scummvm/scummvm/saga
 > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15607
 > 
 > Modified Files:
 > 	music.cpp 
 > Log Message:
 > But surely we should still call setGM(true) in the GM case,
 > right...?
Well. I did not dp it because it has no effect in case of MT-32. 

instrument remapping is performed in this conditional:

saga/music.cpp> } else if ((b & 0xF0) == 0xC0 && !_isGM && !_nativeMT32) {
saga/music.cpp>	    b = (b & 0xFFFF00FF) | mt32_to_gm[(b >> 8) & 0xFF] << 8;

i.e. it does not remap because it's native MT32. After all MT32 is not
GM, so actually it should be setGM(false) for it.


Eugene






More information about the Scummvm-devel mailing list