[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm: [23565] scummvm/trunk/engines/scumm

Johannes Schickel lordhoto at gmail.com
Sat Jul 22 19:15:43 CEST 2006


Max Horn wrote:

> Gah, I wanted to stop monitoring... Anyway, so it seems there is a
> problem, and once more, the symptoms get fixed, not the problem... isn't
> it likely that many more engines and a lot more code are going to be
> affected?
> 

Using packed structs in general is a bad idea, since it isn't supported
on all compilers anyway, maybe you noticed the workaround for
the size of the info header struct for Palm before. So I would say here
the packed structs are the problem and these got fixed for this bit of
the ScummVM code.

> Maybe we have to revert the GCC_PACK removal, maybe something else is
> needed, one will have to investigate to find out the actual cause of the
> problem and how to fix it properly. But just patching up the bits step
> by step will take us ages to and lots of pain before we have covered up
> all holes, won't it?
> 

We revert the GCC_PACK remove and fix it for some systems then, instead
of fixing it now for *all* systems? I don't know if that's any better
than changing all code which relies on packed structs, which takes maybe
longer but is IMHO a much better solution. Of course a mail to -devel
would be nice to have here... (maybe I should write one)

// Johannes





More information about the Scummvm-devel mailing list