[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm: [25632]scummvm/trunk/engines/agos

Travis Howell kirben at optusnet.com.au
Tue Feb 20 00:26:00 CET 2007


From: "Max Horn" <max at quendi.de>
> Am 16.02.2007 um 14:55 schrieb kirben at users.sourceforge.net:
>
>> Revision: 25632
>>           http://scummvm.svn.sourceforge.net/scummvm/?
>> rev=25632&view=rev
>> Author:   kirben
>> Date:     2007-02-16 05:55:01 -0800 (Fri, 16 Feb 2007)
>>
>> Log Message:
>> -----------
>> Add support for using soundtrack from the Simon the Sorcerer 1 -
>> Music Enhancement Project.
>
> That's good, I guess.
>
> However, I disagree with the way it is implemented, in particular, I
> object against (ab)using (IMO) the AudioCDManager to do this.
>
> The AudioCDManager was written to do one very specific thing: Support
> playback of Audio CD tracks for games that use this. Including
> playback from the actual Audio CD (which it will always attempt if an
> Audio CD is available -- even though it makes no sense to even *try*
> this for this "Music Enhancement Project"). Or, failing that, via
> loading & playing track1.* files in various formats.

Actually I would call that an advantage, it allows the use of music via CD 
audio, if people wanted to create their own custon CD of the game, with the 
soundtrack from the Music Enhancement project included, for these specific 
games.

> Also, there is usually no clean mapping between "track numbers" and
> song identifiers. Eugene today asked me whether it's OK to add some
> kind of "tracks.toc" index which can be used to map track IDs to nice
> filenames. IMO, the desire to do this is a clear indicator that we
> are trying to bend a piece of code to do things it was never intended
> for.

The feature was requested for the use of SAGA engine and I don't see the 
actual need for this feature to even be added into ScummVM. Only the Music 
Enhancement Project has permission to replace the original sound tracks used 
by specific games, so the actual track names are irrevlant. We shouldn't be 
encouraging the use of replacement music in games, by people in any other 
ways at all.

> Yes, I know that using AudioCDManager is the easiest and quickest way
> to get this custom "tracks" support up and running. But I think it's
> in fact the quick & dirty "solution". If the current code, as it is
> in the AGOS engine, is enough to completely fulfill all your needs,
> well, then I guess I could live with it. But as soon as people want
> to start adding things like track name mapper tables to
> AudioCDManager, I feel very strongly that we are heading in the wrong
> direction.

But the AudioCDManager does provide all the requirements for using the 
soundtrack from the Music Enhancement Project in Simon the Sorcerer 1 under 
ScummVM, which is why I used this method. 





More information about the Scummvm-devel mailing list