[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[33212] scummvm/trunk/common/hashmap.h

[Max Horn]

Hi Lars, hi all

so you disabled USE_HASHMAP_MEMORY_POOL  for Symbian (see quotes below).
May I ask in which way USE_HASHMAP_MEMORY_POOL is system dependant? I.e.
what broke, exactly? In theory, the memory pool code should actually be
quite portable. Before disabling it conditionally on some platforms,  and
before resolving this FIXME, we really would need to know in how far it
causes problems :).

Also, to the rest of our porters: Are there any other ports who have
troubles with this?

Cheers,
Max

Am 22.07.2008 um 20:09 schrieb anotherguest at users.sourceforge.net:
>
> Revision: 33212
>          http://scummvm.svn.sourceforge.net/scummvm/?rev=33212&view=rev
> Author:   anotherguest
> Date:     2008-07-22 19:09:10 +0000 (Tue, 22 Jul 2008)
>
> Log Message:
> -----------
> Disable hashmemory pool for Symbian OS
>
> Modified Paths:
> --------------
>    scummvm/trunk/common/hashmap.h
>
> Modified: scummvm/trunk/common/hashmap.h
> ===================================================================
> --- scummvm/trunk/common/hashmap.h	2008-07-22 18:53:22 UTC (rev 33211)
> +++ scummvm/trunk/common/hashmap.h	2008-07-22 19:09:10 UTC (rev 33212)
> @@ -58,7 +58,13 @@
> #include "common/str.h"
> #include "common/util.h"
>
> +// FIXME: Since this define is very system dependant,
> +// it should be moved to the appropriate H file instead.
> +// Portdefs might be a good location for example
> +#if !defined(__SYMBIAN32__)
> #define USE_HASHMAP_MEMORY_POOL
> +#endif
> +
> #ifdef USE_HASHMAP_MEMORY_POOL
> #include "common/memorypool.h"
> // FIXME: we sadly can't assume standard C++ to be present