[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[33212] scummvm/trunk/common/hashmap.h

Lars Persson larspp at hotmail.com
Wed Jul 23 11:37:43 CEST 2008


Hi Max, hi all! 
Well the reason for me disabling this feature, is exactlity whats mentioned in the comment for the define. SymbianOS does not have <new> by default and adding support for it is not trivial, but doable. (Needs linking against different libraries, addition of new H file etc.

If the memorypool could be used without <new> there should be no problems with Symbian OS in this regard, as far as I know.

best regards
Lars

> Date: Wed, 23 Jul 2008 11:22:58 +0200
> From: max at quendi.de
> To: anotherguest at users.sourceforge.net
> CC: scummvm-devel at lists.sourceforge.net
> Subject: Re: [Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[33212] scummvm/trunk/common/hashmap.h
> 
> Hi Lars, hi all
> 
> so you disabled USE_HASHMAP_MEMORY_POOL  for Symbian (see quotes below).
> May I ask in which way USE_HASHMAP_MEMORY_POOL is system dependant? I.e.
> what broke, exactly? In theory, the memory pool code should actually be
> quite portable. Before disabling it conditionally on some platforms,  and
> before resolving this FIXME, we really would need to know in how far it
> causes problems :).
> 
> Also, to the rest of our porters: Are there any other ports who have
> troubles with this?
> 
> Cheers,
> Max
> 
> Am 22.07.2008 um 20:09 schrieb anotherguest at users.sourceforge.net:
> >
> > Revision: 33212
> >          http://scummvm.svn.sourceforge.net/scummvm/?rev=33212&view=rev
> > Author:   anotherguest
> > Date:     2008-07-22 19:09:10 +0000 (Tue, 22 Jul 2008)
> >
> > Log Message:
> > -----------
> > Disable hashmemory pool for Symbian OS
> >
> > Modified Paths:
> > --------------
> >    scummvm/trunk/common/hashmap.h
> >
> > Modified: scummvm/trunk/common/hashmap.h
> > ===================================================================
> > --- scummvm/trunk/common/hashmap.h	2008-07-22 18:53:22 UTC (rev 33211)
> > +++ scummvm/trunk/common/hashmap.h	2008-07-22 19:09:10 UTC (rev 33212)
> > @@ -58,7 +58,13 @@
> > #include "common/str.h"
> > #include "common/util.h"
> >
> > +// FIXME: Since this define is very system dependant,
> > +// it should be moved to the appropriate H file instead.
> > +// Portdefs might be a good location for example
> > +#if !defined(__SYMBIAN32__)
> > #define USE_HASHMAP_MEMORY_POOL
> > +#endif
> > +
> > #ifdef USE_HASHMAP_MEMORY_POOL
> > #include "common/memorypool.h"
> > // FIXME: we sadly can't assume standard C++ to be present
> 
> 
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel

_________________________________________________________________
Connect to the next generation of MSN Messenger 
http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source=wlmailtagline
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20080723/fbb2d1ce/attachment.html>


More information about the Scummvm-devel mailing list