[Scummvm-devel] Change regarding the dialogs in the SCUMM engine
Max Horn
max at quendi.de
Sat Sep 20 17:46:31 CEST 2008
Am 20.09.2008 um 17:24 schrieb Filippos K:
> (note: resending this, as it seems it hasn't been delivered.
> Apologies if you get it twice for some reason)
>
> Hello everyone
>
> As Max already mentioned, there is work being done on allowing
> engines to specify that they wish to have a save/load etc menu to
> the GMM. In the SCUMM engine, the dialogs.* files contain a lot of
> the code that might be used for this task. However, there is a part
> which is SCUMM specific: the function InfoDialog::queryResString().
> This gets a string ID and returns an appropriate string depending on
> the SCUMM game version used, from appropriate statically defined
> arrays inside dialogs.cpp (string_map_table_v8, string_map_table_v7
> and so on).
>
> The plan is to either move this function and the associated arrays
> outside dialogs.cpp or remove it altogether, and pass strings to
> InfoDialog instead of resource numbers.
>
> The question is: what would be a better idea? Replace calls with
> resource numbers with actual strings, or move the static string
> arrays outside dialogs.cpp?
Neither. Just leave it where it is. The InfoDialog class is SCUMM
specific. You don't need it for the GMM and the save/load menu. You
only need ScummMenuDialog, SaveLoadChooser, maybe ConfigDialog.
Bye,
Max
More information about the Scummvm-devel
mailing list