[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[43022] scummvm/branches/gsoc2009-draci/engines/draci

[Robert Špalek]

On Sun, Aug 2, 2009 at 6:48 PM, <dkasak13 at users.sourceforge.net> wrote:

> Revision: 43022
>          http://scummvm.svn.sourceforge.net/scummvm/?rev=43022&view=rev
> Author:   dkasak13
> Date:     2009-08-03 01:48:15 +0000 (Mon, 03 Aug 2009)
>
> Log Message:
> -----------
> * Fixed bug which made characters talk with the wrong colour; the colour
> indexes are indexed from 1 in the data files so we need to subtract 1.
>


> Modified: scummvm/branches/gsoc2009-draci/engines/draci/game.cpp
> ===================================================================
> --- scummvm/branches/gsoc2009-draci/engines/draci/game.cpp      2009-08-03
> 01:21:04 UTC (rev 43021)
> +++ scummvm/branches/gsoc2009-draci/engines/draci/game.cpp      2009-08-03
> 01:48:15 UTC (rev 43022)
> @@ -54,7 +54,7 @@
>        for (i = 0; i < numPersons; ++i) {
>                _persons[i]._x = personData.readUint16LE();
>                _persons[i]._y = personData.readUint16LE();
> -               _persons[i]._fontColour = personData.readByte();
> +               _persons[i]._fontColour = personData.readByte() - 1;
>

I don't believe this is right.  FonColor is byte (0..255) and therefore it
cannot contain numbers 1..256 which you would need to index the palette with
subtracting 1.  maybe try the solution I have just sent to you.
-- 
Robert Špalek <rspalek at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090802/d07ba02a/attachment.html>