[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[38376] scummvm/trunk/engines/sci/gfx/gfx_res_options. cpp

Lars Persson anotherguest at users.sourceforge.net
Tue Feb 17 08:39:48 CET 2009


Hi!
Actually the isblank was a #define only active for WIN32 builds. But of
course beeing able to remove dead code would be the best thing to do. :-)

And it seems like there are a couple of functions in that file that are not
beeing used.
Cheers
Lars

2009/2/16 Max Horn <max at quendi.de>

>
> Am 16.02.2009 um 20:20 schrieb Max Horn:
>
>
>
>> Am 16.02.2009 um 19:40 schrieb anotherguest at users.sourceforge.net:
>>
>>  Revision: 38376
>>>        http://scummvm.svn.sourceforge.net/scummvm/?
>>> rev=38376&view=rev
>>> Author:   anotherguest
>>> Date:     2009-02-16 18:40:36 +0000 (Mon, 16 Feb 2009)
>>>
>>> Log Message:
>>> -----------
>>> isblank is not available on all platforms. Needs to be handled in a
>>> different way.
>>>
>>
>> Where is it not available? Symbian?
>>
>> We could simply provide
>>
>> #define scummvm_isblank(c) ((c) == ' ' || (c) == '\t' || (c) == '\n'
>> || (c) == '\r')
>>
>> in either a sci specific header, or if other stuff uses it, in
>> scummsys.h.
>>
>> That would on the long run probably be more portable than trying to
>> redefine isblank.
>>
>
> Looking at this again, my def of isblank was of course wrong, it should
> only check space and tab (and Lars actually provided code for that, whoops
> :-). Anyway, I wonder if isblank could be replaced by isspace there.
>
> Furthermore, I wonder about ./gfx/gfx_res_options.cpp -- for what is this
> code used? It also seems to contain some unused stuff, like
> gfx_update_conf() -- in fact, removing that function and then removing all
> the stuff that was only used by it, gets rid of all occurances of isblank().
> Now I wonder whether it would be safe to just do that...
>
>
> Bye,
> Max
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090217/59a232c2/attachment.html>


More information about the Scummvm-devel mailing list