[Scummvm-devel] Nasty regression fixed in SAGA

[Willem Jan Palenstijn]

On Fri, Feb 20, 2009 at 10:50:26AM +0000, Filippos Karapetis wrote:
> 
> Hello
> 
> I've just fixed a nasty regression from the script system rewrite
> (commit #35670), which will cause crashes under certain conditions,
> and probably makes SAGA games non-completable. 
> 
> When a script thread is waiting for another thread, the current
> instruction offset should not be modified. The thread processing
> function would incorrectly continue in some special cases, and would
> incorrectly alter the current instruction offset. This becomes
> apparent in some special cases only, which made it hard to spot -
> plus, SAGA games have not been tested for 0.13.0, so there weren't any
> reports for this.

Ouch.

> This change SHOULD go to the 0.13.0 branch, but we've already tagged...

Please do commit it to the branch. If we re-tag or do a 0.13.1, we'll
need it there.

It would probably also be a very good idea to actually test a full SAGA
game on short notice after this patch has been committed to the branch.
Any volunteers?


-Willem Jan