[Scummvm-devel] Engine::go() vs. Engine::init()

Johannes Schickel lordhoto at gmail.com
Sun Feb 22 22:56:40 CET 2009


Torbjörn Andersson schrieb:
>> can anybody think of a good reason why we wouldn't want to merge the  
>> two methods Engine::go() and Engine::init() into a single one, like  
>> Engine::run() ?
>>     
>
> I've forgotten why go() was split into init() and go() in the first
> place (see revision 15865). I can see that back then go() was changed to
> void, so I guess the intention was to move anything that could go wrong
> into its own function.
>
> Since both now return Common::Error, I guess they may as well be re-merged.
>   

I don't really see any real reason why we should keep both methods. 
Generally spoken I would think that initialization (init) and usage (go) 
should be split though, but there's no real advantage in our case, so 
I'm fine with a merge.

// Johannes




More information about the Scummvm-devel mailing list