[Scummvm-devel] SCI: line drawing functions

[Filippos Karapetis]

Hello

I was having a look at SCI's line drawing functions, and have some questions
- would it be safe to replace the line drawing functions inside gfx/gfx_support.cpp and gfx/gfx_line.cpp with our Graphics::drawThickLine() function? I personally don't see any issues with this, and I've tested some SCI games with this change, and they seem to run correctly, but I just wanted to get a second opinion. Our line code is in graphics/primitives.cpp and is based on Bresenham's line algorithm.
- it seems that there is provision in the code to draw thicker lines than 1 pixel, but it seems only line thickness of 1 is used... so we could replace this with our simpler Graphics::drawLine function, instead of Graphics::drawThickLine, right?

Regards
Filippos

_________________________________________________________________
Windows Live™: Discover 10 secrets about the new Windows Live.  
http://windowslive.com/connect/post/jamiethomson.spaces.live.com-Blog-cns!550F681DAD532637!7540.entry?ocid=TXT_TAGLM_WL_t2_ugc_post_022009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090223/ba5b36a0/attachment.html>