[Scummvm-devel] SCI: Some more TODOs

Max Horn max at quendi.de
Tue Feb 24 04:06:38 CET 2009


Am 23.02.2009 um 18:59 schrieb Andre Heider:

> Max Horn wrote:
>
>> * Replace sci_gettime and sci_get_current_time by   
>> OSystem::getTimeAndDate and OSystem::getMillis
>> -> You first need to find out which is used where: Des the code try  
>> to  determine the current time? Use getTimeAndDate(). Does it try  
>> to  measure something, regulate timing? Using getMillis. It is  
>> possible  that some code actually really wants to get a higher  
>> resolution than  milli seconds, in that case get back to us and  
>> let's discuss what to do.
>
> Because the Wii libc port doesn't implement the used time functions  
> freesci uses, i started working on this. Since I'm new to the sci  
> engine code I'll attach it to this mail prior to breaking  
> something :-)
>
> I'm sure I missed something, but my few games still seem to run  
> fine. Please comment/review, thanks!

It looks good enough to me. Thanks! Feel free to commit it.

Max




More information about the Scummvm-devel mailing list