[Scummvm-devel] SCI file handling revamp

[Max Horn]

Am 27.02.2009 um 12:31 schrieb Willem Jan Palenstijn:

> On Fri, Feb 27, 2009 at 12:11:09PM -0500, Max Horn wrote:
>>> On Fri, Feb 27, 2009 at 01:26:32PM +0100, Andre Heider wrote:
>>>> On Thu, Feb 26, 2009 at 5:50 PM, Max Horn <max at quendi.de> wrote:
>>>>
>>>>> Actually, I might change the current warning that is produced when
>>>>> trying to write to a file opened in read-mode, and vice versa,  
>>>>> to an
>>>>> error, to ensure I get plenty of reports quickly *ggg*.
>>>>
>>>> Nice plan, here's the first:
>>>>
>>>> starting LSL3 with "LARRY3.DRV" and "RESOURCE.LL3" removed from the
>>>> gamedir:
>>
>>
>> Thanks. Did this work before my changes, though? Does it work with
>> Sierra's SCI (SSCI)?
>
> I verified this with Sierra SCI:
>
> Starting LSL3 without LARRY3.DRV works fine, and creates LARRY3.DRV
> (eventually).
>
> This also worked before your changes, but after your changes error()s
> out in getFileFromHandle() called by kFClose().

Well, we could change them back to warnings, but I still would like to  
understand why they are triggered. You mean, LSL3 tries to open the  
file, fails to do so, then closes the file (even though it never  
managed to open it) ?

Also, when the file is missing, do they just populate it with data  
from scratch? What is it used for, actually?


Bye,
Max