[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[42257] scummvm/trunk/graphics

Johannes Schickel lordhoto at gmail.com
Wed Jul 8 18:00:03 CEST 2009


Max Horn wrote:
> Am 08.07.2009 um 09:13 schrieb thebluegr at users.sourceforge.net:
>
>   
>> Revision: 42257
>>          http://scummvm.svn.sourceforge.net/scummvm/? 
>> rev=42257&view=rev
>> Author:   thebluegr
>> Date:     2009-07-08 07:13:56 +0000 (Wed, 08 Jul 2009)
>>
>> Log Message:
>> -----------
>> The ENABLE_* flags are only checked for *.cpp files in MSVC, so move  
>> the ENABLE_* checks to sjis.cpp to fix compilation under MSVC
>>
>>     
>
> I don't understand, what does that mean??? Do you mean to say these  
> flags are only #defined in the .cpp files? That would be most weird.
>
> Or maybe MSVC doesn't #define them globally at all but rather relies  
> on these values being set from config.h -- in that case, the solution  
> would be to add an #include "common/scummsys.h" at the top of the  
> header.
>
> But moving the check from the header file to the source file seems  
> wrong.
>   

I just can agree with Max here.

Also if such problems occur with build system I would prefer to get a 
noticed dropped instead of a commit of an ugly hack into our code.

This makes me wonder our Lands of Lore code also has defines checks in 
the header (but also in the source files there), will the header checks 
just be skipped?

// Johannes




More information about the Scummvm-devel mailing list