[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[39009] scummvm/trunk/engines/sci/sfx

Max Horn max at quendi.de
Sun Mar 1 17:16:13 CET 2009


Am 01.03.2009 um 06:02 schrieb Jordi Vilalta:

> 2009/3/1  <fingolfin at users.sourceforge.net>:
>> Revision: 39009
>>          http://scummvm.svn.sourceforge.net/scummvm/?rev=39009&view=rev
>> Author:   fingolfin
>> Date:     2009-03-01 06:02:42 +0000 (Sun, 01 Mar 2009)
>>
>> Log Message:
>> -----------
>> SCI: Removed unused pause/resume methods from the mixer, and  
>> rewrote the feeds handling to use Common::List
>
> Commits 39006-39010 (intermediate revisions aren't compilable) added a
> regression in at least some SCI1 games: SQ1, PQ3 and the Castle of Dr.
> Brain Demo crash early in the intro.

Sorry for both of that:
* the crash was a stupid mistake but wjp seems to already have fixed it
* that intermediate revisions are not compilable is also annoying,  
because it breaks useful stuff like "git bisect". The weird thing is:  
I could swear that I committed them all, using "git svn dcommit", and  
that git st showed me a clean tree, yet when i compiled a regular SVN  
checkout, I noticed the compile error. I must have misused git somehow  
(or maybe it was a bug, but human mistake still seems more plausible).

Sorry and thanks to wjp,
Max




More information about the Scummvm-devel mailing list