[Scummvm-devel] templates, visuals, getDevices()
Max Horn
max at quendi.de
Mon Mar 2 04:18:58 CET 2009
Hi Rainer,
thank you for your submission, it is much appreciated. Though in the
future, you may want to submit this via our patch tracker (linked from
e.g. scummvm.org), to make sure the patch is not lost / forgotten. :-)
Am 01.03.2009 um 16:04 schrieb Rainer M. Canavan:
> Hi,
>
> to compile the branch-0-13-0, I had to make some minor adjustments
> to common/list.h, common/hashmap.h and engines/groovie/graphics.cpp.
> If those changes don't break builds with gcc and other compilers,
> I'd appreciate if they could be appiled to branch and trunk.
The first two (in common/) do break compilation on GCC, and they are
semantically incorrect. So sorry, but no way they are going to be
added like that. Explanation: They add forward declarations for
classes (resp. class tempaltes) that do not exist. I.e. there is no
class Iterator in the global namespace, nor in namespace Common.
Rather, the class's full name is Common::List::Iterator. Same for
IteratorImpl in hashmap.h
Maybe if you tell us what errors you get, with which compiler, we can
try to find a portable solution to your problem.
The change in groovie OTOH fixes a "bug" in groovie code, and should
be commited to both trunk and the 0.13.x branch!
> There's a problem with the main menu and the ctrl-F5 in-game
> scummvm menu (or SDL?) on one of my machines, the modern theme
> is mint green instead of red/orange, but all game graphics are OK.
> The visual of the scummvm window is as follows:
>
> visual id: 0x39
> class: TrueColor
> depth: 15 planes
> available colormap entries: 32 per subfield
> red, green, blue masks: 0x1f, 0x3e0, 0x7c00
> significant bits in color specification: 8 bits
>
> On another box where things look normal, the masks are reversed:
> red, green, blue masks: 0x7c00, 0x3e0, 0x1f
Yeah, that's a known issue that is fixed in trunk, but we still use
the old code in the branch.
>
> The second patch is an attempt to populate the getDevices()
> function of the dmedia midi driver.
Somebody else will have to comment on that one, as I don't even know
what "dmedia" is :)
Bye,
Max
More information about the Scummvm-devel
mailing list