[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[40351] scummvm/trunk/sound/softsynth/opl/opl.h

Filippos Karapetis philipk79 at hotmail.com
Fri May 8 12:51:51 CEST 2009


> Date: Thu, 7 May 2009 22:17:48 +0200
> From: lordhoto at gmail.com
> To: max at quendi.de
> CC: philipk79 at hotmail.com; scummvm-devel at lists.sourceforge.net
> Subject: Re: [Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[40351] scummvm/trunk/sound/softsynth/opl/opl.h
> 
> Max Horn wrote:
> >
> > Am 07.05.2009 um 21:38 schrieb Johannes Schickel:
> >
> >> Filippos Karapetis wrote:
> >>> In that case, we can just remove the files from the VS project files
> >>> so that they won't be compiled straight away. Thus, the .cpp file does
> >>> not need to be renamed...
> >>
> >> I thought about that too, but if someone might want to edit the code via
> >> VS that would be much more inconvenient than just renaming the files
> >> IMHO. Also it protects other builds envs from doing the same mistake
> >> (XCode projects maybe).
> >
> > With any decent IDE I used in the past (XCode, Eclipse, Codewarrior), 
> > it was possible to add .cpp files and mark them as "do not compile", 
> > just to facilitate uses exactly like this. Surely VS also can do that?
> >
> 
> I don't know to be honest, I thought so too. I guess the main problem 
> was that nowhere it is mentioned that the file is only a 'template' for 
> code creation. I don't like this template thing too much though, my plan 
> is to (eventually) get rid of it in the long run. Of course doing 
> branches instead of the #ifdefs might have impacts on execution speed. 
> For now I would be fine with renaming them back to .h/.cpp and adding a 
> slight notice about this fact in the .cpp file, of course I hope people 
> updating project files will read such notes :-).
> 
> // Johannes


Indeed, there is an option to flag a file so it won't be compiled in
MSVC. I renamed the two files back to opl.h and opl.cpp, marking
opl.cpp as "do not compile", and it compiles fine under MSVC. Should I
committhis?

Filippos


_________________________________________________________________
HotmailĀ® goes with you. 
http://windowslive.com/Tutorial/Hotmail/Mobile?ocid=TXT_TAGLM_WL_HM_Tutorial_Mobile1_052009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20090508/64909499/attachment.html>


More information about the Scummvm-devel mailing list