[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[48147] scummvm/trunk/engines/draci/music.cpp

Robert Špalek rspalek at gmail.com
Sat Feb 27 23:03:35 CET 2010


thank you very much!

out of curiosity, when could it happen that the channel cannot be allocated?
 is it that on some architectures, although MIDI is supported in general
(and thus enabled in the game engine), some channels (perhaps above some
limit) fail to allocate?


On Sat, Feb 27, 2010 at 7:54 AM, <jvprat at users.sourceforge.net> wrote:

> Revision: 48147
>          http://scummvm.svn.sourceforge.net/scummvm/?rev=48147&view=rev
> Author:   jvprat
> Date:     2010-02-27 15:54:31 +0000 (Sat, 27 Feb 2010)
>
> Log Message:
> -----------
> DRACI: Don't try to set the volume for channels that couldn't be allocated
> (fixes bug #2907954: "DRAGON: Crash in Intro")
>
> Modified Paths:
> --------------
>    scummvm/trunk/engines/draci/music.cpp
>
> Modified: scummvm/trunk/engines/draci/music.cpp
> ===================================================================
> --- scummvm/trunk/engines/draci/music.cpp       2010-02-27 11:44:35 UTC
> (rev 48146)
> +++ scummvm/trunk/engines/draci/music.cpp       2010-02-27 15:54:31 UTC
> (rev 48147)
> @@ -127,7 +127,8 @@
>                _channel[channel] = (channel == 9) ?
> _driver->getPercussionChannel() : _driver->allocateChannel();
>                // If a new channel is allocated during the playback, make
> sure
>                // its volume is correctly initialized.
> -               setChannelVolume(channel);
> +               if (_channel[channel])
> +                       setChannelVolume(channel);
>        }
>
>        if (_channel[channel])
>
>
> This was sent by the SourceForge.net collaborative development platform,
> the world's largest Open Source development site.
>
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Scummvm-cvs-logs mailing list
> Scummvm-cvs-logs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-cvs-logs
>



-- 
Robert Špalek <rspalek at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20100227/bf43ffec/attachment.html>


More information about the Scummvm-devel mailing list