[Scummvm-devel] Compile error in DC and PSP ports

[yotam barnoy]

Looks like a copy and paste error. I'd prefer to have the function removed
in both trunk and the 1.1.0 branch.

Yotam

On Thu, Mar 18, 2010 at 10:22 PM, Max Horn <max at quendi.de> wrote:

> Hi folks,
>
> I am afraid some of my commits today broke compilation of the DC and PSP
> ports. I since then fixed this, but the reason for the compile errors is
> actually a potential issue / bug in the underlying code, so it's best if you
> guys review this:
>
> Basically, both the DC and PSP backends subclass FilePluginProvider, and
> overload the addCustomDirectories method. However, in the base class, its
> signature is:
>
>  virtual void addCustomDirectories(Common::FSList &dirs) const;
>
> while in your subclasses, it was
>
>  virtual void addCustomDirectories(Common::StringList &dirs) const;
>
> Since I renamed StringList to StringArray today, and moved its definition,
> this caused compile errors in your files. But the actual issue at hand is
> clearly a mismatch in signature; your custom methods were never being
> called.
>
> I changed the signatures of the functions, and adjusted the code to make it
> compile. However, I cannot verify that it works now, e.g. I don't know
> whether your FSNode's handle "/". So, please test and review this. See also
> <http://scummvm.svn.sourceforge.net/scummvm/?rev=48290&view=rev>
>
>
> Extra warning: This issue also exists in the 1.1.0 branch, i.e. you have
> addCustomDirectories methods which are not being called. So I guess it
> should be either fixed there, too, or else the custom addCustomDirectories
> should be removed in both branch and trunk.
>
>
> Cheers,
> Max
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20100318/1dfbd6fd/attachment.html>