[Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[53456] scummvm/trunk/engines/scumm/he/wiz_he.cpp

Travis Howell kirben at optusnet.com.au
Fri Oct 15 00:13:11 CEST 2010


Why did you commit this untested patch? and to both branches? the patch 
was only just added to that tracker item, and was waiting for further 
feedback.

That patch isn't the correct method to fix cursors, and would cause 
numerous patch glitches on a BE system, when any manipulation of 
wizImages is used. Since the decoding methods for wizImages rely on the 
palette been stored in LE.

Please revert those changes.

On 15/10/2010 5:19 AM, sev at users.sourceforge.net wrote:
> Revision: 53456
>            http://scummvm.svn.sourceforge.net/scummvm/?rev=53456&view=rev
> Author:   sev
> Date:     2010-10-14 18:19:51 +0000 (Thu, 14 Oct 2010)
>
> Log Message:
> -----------
> SCUMM: Fix bug #2952298 with 16-bit HE cursors on Amiga
>
> Bug #2952298: "HE (16Bit): Inventory items (Cursors) have wrong color"
> This appeared to be generic BE bug. Thanks to jvprat for nailing it down
> and providing the patch.
>
> Modified Paths:
> --------------
>      scummvm/trunk/engines/scumm/he/wiz_he.cpp
>
> Modified: scummvm/trunk/engines/scumm/he/wiz_he.cpp
> ===================================================================
> --- scummvm/trunk/engines/scumm/he/wiz_he.cpp	2010-10-14 13:19:32 UTC (rev 53455)
> +++ scummvm/trunk/engines/scumm/he/wiz_he.cpp	2010-10-14 18:19:51 UTC (rev 53456)
> @@ -363,7 +363,7 @@
>   		break;
>   	case kDstMemory:
>   	case kDstResource:
> -		WRITE_LE_UINT16(dstPtr, color);
> +		WRITE_UINT16(dstPtr, color);
>   		break;
>   	default:
>   		error("writeColor: Unknown dstType %d", dstType);
>
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2&  L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Scummvm-cvs-logs mailing list
> Scummvm-cvs-logs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-cvs-logs
>




More information about the Scummvm-devel mailing list