[Scummvm-devel] Changes to plugins and config manager

[yotam barnoy]

Calls to EngineManager::findGame() don't have to be made when the game
domain is active. The only thing passed in is the gameid, which is not
enough to find the appropriate domain or to set the value in the
appropriate domain (e.g. a gameid of sci is used for all SCI games).
That's why I had to make a mapping of gameid to the plugin file. A
different solution would involve changing the findGame() function to
receive the game domain name and making sure it's always called with
that name in all instances.

Yotam

On Tue, Jan 4, 2011 at 4:10 PM, Eugene Sandulenko <sev at scummvm.org> wrote:
> On Tue, 4 Jan 2011 14:57:31 +0200
> yotam barnoy <yotambarnoy at gmail.com> wrote:
>
>> A scummvm.ini file with uncached plugins enabled looks like the
>> following. The plugin_files domain contains gameid, plugin file path
>> values:
>> [plugin_files]
>> agi=agi.plg
>> atlantis=scumm.plg
>> sci=sci.plg
>> gob=gob.plg
>> tentacle=scumm.plg
> That's what I thought, but I still fail to understand why you did not
> add plugin=scumm.plg to relevant gameid entry. After all, you're
> filling out these values on attempt to run the game for the first time,
> and at this point you do know the game domain value.
>
>
> Eugene
>