[Scummvm-devel] Changes to plugins and config manager

[yotam barnoy]

> Oh: Just FYI at least in the past (that might be the long gone past though),
> not every game domain had an gameid included. In such a case the target name
> was considered to be the gameid (there is still code which supports this, in
> the launcher for example). I am not sure whether that still applies with our
> current code base (it definitly wouldn't work with your new code ;-). Guess
> one should take a look into that.

That's a good point (which Max also made btw).

Our current code seems to always add the gameid. Regarding really old
config files (and I'm also not sure if and how many of these exist),
the situation is this: since they don't have gameids, they'll get
loaded as miscDomains. They won't appear in the launcher but they'll
still be maintained in the config file. The user may add them again,
and then there will potentially be 2 domains with the same name, one a
miscDomain and one a gameDomain. Currently, when loading from the
config file, we check to see if the domain name already exists in the
same map (e.g. when we load a miscDomain, we check that the
miscDomainMap doesn't already have the same miscDomain). What we could
do is, when loading a gameDomain, we could check for a miscDomain with
the same name and delete it if needed. That way the ghost entry will
eventually be deleted, though it won't damage anything if it stays (as
far as I can tell). Additionally, we should put the priority of
gameDomains above miscDomain ie. when searching for a domain, the
gameDomains should be searched first (currently I have it the other
way around).

Yotam