[Scummvm-devel] MT-32 option causing crashes / silent exits in 1.3.0

[Florian Kagerer]

I have now committed an attempt to fix this.

While I did as much testing as possible with certain engines (KYRA, some
SCUMM, some SCI) I might have overlooked something. It would be really neat
if you guys could try this with your own engine/platform (with or without
rom files).

You want to make sure not to attempt MT-32 detection in your engine if you
don't need one (e.g. for non-DOS versions of games), because this might
trigger unnecessary detection failure warnings.
This is something I noticed (and fixed) in KYRA where you would get notified
about a failed MT-32 detection attempt even when trying to start the PC-98
version of the game (which has its own dedicated audio tracks and doesn't
support any sort of MIDI).

Cheers,

Florian

> -----Ursprüngliche Nachricht-----
> Von: Max Horn [mailto:max at quendi.de]
> Gesendet: Sonntag, 5. Juni 2011 11:26
> An: scummvm-devel.lists.sourceforge.net devel
> Betreff: [Scummvm-devel] MT-32 option causing crashes / silent exits in
> 1.3.0
> 
> Hi there,
> 
> we got several reports on the forums by now (and on the bug tracker)
> about people suffering from ScummVM crashing resp. silently exiting due
> to invalid MIDI settings, typically involving MT-32. Most of these
> users probably never selected MT-32 consciously. Rather, we changed
> ScummVM in some way that causes this.
> 
> I am sure that for every report we get, at least two other users give
> up in frustration. Veeery bad. :( And this issue is not new, either, we
> had reports on this before, I think. I really hope "somebody" will
> start working on fixes for master and for the apparently quite
> necessary 1.3.1.
> 
> So, in a nutshell: If the MT-32 emu is selected but not available (not
> compiled in, missing control ROM files, whatever), we should not
> silently exit. If we *must* exit, then only with an error dialog that
> explains the situation. Better, though, to use a fallback, as we used
> to do in the past.
> 
> I have some more stuff to say, but that's the core, and I don't want to
> scare off people with my overly-long emails :)
> 
> 
> Cheers,
> Max
> -----------------------------------------------------------------------
> -------
> Simplify data backup and recovery for your virtual environment with
> vRanger.
> Installation's a snap, and flexible recovery options mean your data is
> safe,
> secure and there when you need it. Discover what all the cheering's
> about.
> Get your free trial download today.
> http://p.sf.net/sfu/quest-dev2dev2
> _______________________________________________
> Scummvm-devel mailing list
> Scummvm-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scummvm-devel