[Scummvm-devel] Strange problem with ARM 2x scaler in WinCE port

Ismail Khatib ikhatib at gmail.com
Fri Jun 10 20:58:44 CEST 2011


Am 10.06.2011 um 20:36 schrieb Willem Jan Palenstijn:

> On Fri, Jun 10, 2011 at 10:59:45AM +0200, Ismail Khatib wrote:
>> Hi all!
>>
>> Yesterday I checked a problem in the WinCE port which was reported in
>> the forums, and after I changed the scaler in my testconfig to 2x  
>> (was
>> using HQ2x before) I could reproduce it. It doesn't occur when the
>> aspect correction is enabled. I could track down the problem to the  
>> file
>> graphics/scaler.cpp; when I change line 180 (#ifdef  
>> USE_ARM_SCALER_ASM)
>> to "#if 0" for example, to disable only this Normal2xARM scaler,
>> everything works perfectly, so I assume the problem really lies  
>> inside
>> graphics/scaler/Normal2xARM.s (but I'm not really sure about this, it
>> could also be in graphics/scaler/scalebit.cpp, but hadn't enough time
>> yesterday to check where exactly the problem lies.
>
> I think I spotted the bug in the ARM assembly. I don't have any  
> access to ARM
> hardware though, so I can't verify this, or even check that it  
> compiles. Could
> you test it?
>
> https://github.com/wjp/scummvm/commit/d7dc2546991f54ccf79d7c6d51936a4c216b45be
>
> -Willem Jan

Thanks a lot Willem, this was perfectly right!
This was indeed the problem. Just tried it out, and it fixes this bug.
I'm appling your fix to master and 1-3-1 now.

Regards,
Cerial




More information about the Scummvm-devel mailing list