[Scummvm-devel] Fwd: Found cause for translation problem

[Thierry Crozat]

Le 20 juin 2011 à 21:51, Simon Sawatzki a écrit :

>> Assuming the (reasonable) priority change is made, is there a risk that 
>> users who use the no-installer ZIP distribution of ScummVM by 
>> extract-overwriting their old copy may end up leaving old files around 
>> which then get interpreted as overrides?
> 
> That was exactly my point in one of the last emails. I got the answer that there are technical steps that will just use the file in the case that it is working to avoid this problem. However, all translations.dat files will be working - they just will miss strings on different degrees. However, there might be included some sort of version number in the .dat files so that ScummVM knows whether to use the files or rather the in-built ones.

I agree with previous comments that embedded files is a step forward and I don't see any real reason why we would want to disable it.

But the update to version 1.4.0 is a good point. Until now I only changed the version in the translations.dat file when the format of the file changed (which happened only once) and not when its content changed (which happens way to often to bump the version each time). But we could decide for the 1.4.0 release to increase the version by one to make sure it does not load translations file from an older release that might be lying around. We could actually do that for each major release. And as Johannes suggested we should also improve the data file loading code to continue looking for the file until it finds one it can load and not stop at the first one it finds even if the format or version is incorrect (I will have a go at it when I find the time, unless somebody beats me to it - but somehow I doubt this will happen).

Thierry