[Scummvm-devel] SaveLoadChooser.PageDisplay vs lowres themes

[Федор]

 Hi! Try Neverhood demo. It crashes if scummvm use Modern theme but Classic is ok.


Субота, 11 студзеня 2014, 19:12 +01:00 ад Johannes Schickel <lordhoto at gmail.com>:
>On 01/11/2014 05:54 PM, Marcus Comstedt wrote:
>> Johannes Schickel < lordhoto at gmail.com > writes:
>>
>>> The hack would still be required, because of the implementation of the
>>> choosers. It's two different classes,
>> But if the theme does not support grid choosers, the class
>> SaveLoadChooserGrid should never be instantiated.
>>
>> In fact, it _must_ not be instantiated, because if it is you'll get
>> the crash I was talking about.  And if you must make sure not to
>> instantiate the class, then what good are additional tests in the
>> methods of that class going to do?  They aren't going to be executed
>> anyway.
>>
>
>The issue is the following: Suppose you start ScummVM in 640x480 (i.e. 
>hires with grid allowed), open the grid based save/load dialog and then 
>use hotkeys to switch to 320x240 while the grid dialog is open, then you 
>get SaveLoadChooserGrid::reflowLayout called with the lowres theme which 
>doesn't allow a grid based dialog and doesn't have the page widget 
>defined => crash. That's what the HACK tries to cover.
>
>// Johannes
>
>
>------------------------------------------------------------------------------
>CenturyLink Cloud: The Leader in Enterprise Cloud Services.
>Learn Why More Businesses Are Choosing CenturyLink Cloud For
>Critical Workloads, Development Environments & Everything In Between.
>Get a Quote or Start a Free Trial Today. 
>http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
>_______________________________________________
>Scummvm-devel mailing list
>Scummvm-devel at lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/scummvm-devel


С уважением, Федор Стрижнёв.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scummvm.org/pipermail/scummvm-devel/attachments/20140111/f3fcffbc/attachment.html>