[Scummvm-devel] ATTN Porters: SaveFileManager API Adjustments

[Marcus Comstedt]

Colin Snover <scummvm-devel at zetafleet.com> writes:

> I have been just peripherally following this discussion, so apologies if
> this has been asked already. Since there seems to be a lot of talking
> about performance, has anyone involved here actually done real-world
> benchmarking to verify that there is actually a performance problem
> caused by this change? If so could you please provide hard data about
> what that actual performance impact is, when this change is made?

I just did a quick test.  Unfortunately I only had space left on the
card for two saves; for better accuracy there should have been a few
more.  I'll redo the test after easter when I've had time to back up
and clean out the cards.

Using a stopwatch, I clocked the time to open the savegame dialog to 2
seconds before adding a listSavefiles operation to each
openForLoading, and 4 seconds after.  As I said, not completely
accurate due to the one second resolution of the stopwatch and due to
relying on my reflexes.

I did also add an internal timer to listSavefiles, which provides a
more accurate measure of how long that specific operation takes.  It
clocked at 409 ms.  So my guesstimate of a 50% increase in time
doesn't seem too far off the bat given that the base time seems to be
in the range of 1-1.5 seconds per save.


  // Marcus