<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'>
Hi Max, hi all! <br>Well the reason for me disabling this feature, is exactlity whats mentioned in the comment for the define. SymbianOS does not have <new> by default and adding support for it is not trivial, but doable. (Needs linking against different libraries, addition of new H file etc.<br><br>If the memorypool could be used without <new> there should be no problems with Symbian OS in this regard, as far as I know.<br><br>best regards<br>Lars<br><br>> Date: Wed, 23 Jul 2008 11:22:58 +0200<br>> From: max@quendi.de<br>> To: anotherguest@users.sourceforge.net<br>> CC: scummvm-devel@lists.sourceforge.net<br>> Subject: Re: [Scummvm-devel] [Scummvm-cvs-logs] SF.net SVN: scummvm:[33212] scummvm/trunk/common/hashmap.h<br>> <br>> Hi Lars, hi all<br>> <br>> so you disabled USE_HASHMAP_MEMORY_POOL for Symbian (see quotes below).<br>> May I ask in which way USE_HASHMAP_MEMORY_POOL is system dependant? I.e.<br>> what broke, exactly? In theory, the memory pool code should actually be<br>> quite portable. Before disabling it conditionally on some platforms, and<br>> before resolving this FIXME, we really would need to know in how far it<br>> causes problems :).<br>> <br>> Also, to the rest of our porters: Are there any other ports who have<br>> troubles with this?<br>> <br>> Cheers,<br>> Max<br>> <br>> Am 22.07.2008 um 20:09 schrieb anotherguest@users.sourceforge.net:<br>> ><br>> > Revision: 33212<br>> > http://scummvm.svn.sourceforge.net/scummvm/?rev=33212&view=rev<br>> > Author: anotherguest<br>> > Date: 2008-07-22 19:09:10 +0000 (Tue, 22 Jul 2008)<br>> ><br>> > Log Message:<br>> > -----------<br>> > Disable hashmemory pool for Symbian OS<br>> ><br>> > Modified Paths:<br>> > --------------<br>> > scummvm/trunk/common/hashmap.h<br>> ><br>> > Modified: scummvm/trunk/common/hashmap.h<br>> > ===================================================================<br>> > --- scummvm/trunk/common/hashmap.h 2008-07-22 18:53:22 UTC (rev 33211)<br>> > +++ scummvm/trunk/common/hashmap.h 2008-07-22 19:09:10 UTC (rev 33212)<br>> > @@ -58,7 +58,13 @@<br>> > #include "common/str.h"<br>> > #include "common/util.h"<br>> ><br>> > +// FIXME: Since this define is very system dependant,<br>> > +// it should be moved to the appropriate H file instead.<br>> > +// Portdefs might be a good location for example<br>> > +#if !defined(__SYMBIAN32__)<br>> > #define USE_HASHMAP_MEMORY_POOL<br>> > +#endif<br>> > +<br>> > #ifdef USE_HASHMAP_MEMORY_POOL<br>> > #include "common/memorypool.h"<br>> > // FIXME: we sadly can't assume standard C++ to be present<br>> <br>> <br>> <br>> <br>> -------------------------------------------------------------------------<br>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge<br>> Build the coolest Linux based applications with Moblin SDK & win great prizes<br>> Grand prize is a trip for two to an Open Source event anywhere in the world<br>> http://moblin-contest.org/redirect.php?banner_id=100&url=/<br>> _______________________________________________<br>> Scummvm-devel mailing list<br>> Scummvm-devel@lists.sourceforge.net<br>> https://lists.sourceforge.net/lists/listinfo/scummvm-devel<br><br /><hr />Connect to the next generation of MSN Messenger <a href='http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source=wlmailtagline' target='_new'>Get it now! </a></body>
</html>