<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'>> * Engine::go() returns the result of shouldRTL(), and this holds for all <br>> engines. Why don't we<br>> move this to the base code instead? I mean, the engine couldn't care <br>> less if it's returning to<br>> the launcher or quitting. The proper place for this check seems to be <br>> scummvm_main, after the<br>> engine has been shutdown and we are out of runGame. The meaning of the <br>> return value for runGame<br>> can be changed to: 0 if the engine couldn't start and 1 if the engine <br>> started and shouldRTL must<br>> be checked.<br><br>This seems like a more cleaner and transparent approach indeed<br> <br>> And now, opinion's corner: speaking of general behaviour, after an engine <br>> is shutdown it should<br>> always go back to the launcher. The only way for a direct quit should be <br>> the GMM dialog. What do<br>> you guys think about this?<br><br>I agree on this, I believe it would be better if engines always return to launcher...<br><br>As for the engine features: I think that currently, most engines support these (i.e.<br>return to launcher, list saves etc), with some notable exceptions where save games<br>are completely handled by scripts. Wouldn't it be better semantically to change these<br>features the other way around, i.e. mark engines that do NOT support them? (e.g.<span style="font-family: monospace;"><br></span>kSupportsRTL -> kDoesNotSupportRTL and so on)<br><br>Also, a question concerning AGI:<br>In cycle.cpp, the following line:<span style="font-family: monospace;"><br></span>if (_game.quitProgNow == 0xff)<br>has been changed to:<span style="font-family: monospace;"><br></span>if (quit() == 0xff)<br><br>This is the part where the game checks if it should be restarted or not<br><pre>This seems a bit weird, as quitProgNow was an integer, but<br>quit() returns a boolean, so I'm unsure if this check will<br>ever be true. <br></pre>In the place where game.quitProgNow was set to 0xff, quitGame() is called instead<br><pre>I'm thinking of changing the weird statement to "if (quit())",<br>but it still doesn't make sense for that part of the code :/<br><br>Regards<br>Filippos<br></pre><br /><hr />Talk to your Yahoo! Friends via Windows Live Messenger. <a href='http://www.windowslive.com/explore/messenger?ocid=TXT_TAGLM_WL_messenger_yahoo_082008' target='_new'>Find Out How</a></body>
</html>