<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
</style>
</head>
<body class='hmmessage'>
I've also made a patch that completely removes MPEG2 playing, and I've rewritten all the BS1 video playing code to the new video player code. The resulting file is about 6-8kb big, and the code is much much much more simplified. As eriktorbjorn said, a lot of the code is simplified (especially for BS1). It is able to play both DXA and Smacker movies without any code
duplication. It also throws a nice error message if it finds MPEG2
cutscenes. I don't have it handy right now, but I can upload it in the
evening. Also, a whole big class is removed (the credits playing code), as it's only used for version 1 MPEG2 files. The credits in BS1 are in Smacker format anyway, but I believe that the credits player was added because the credits themselves were unreadable in MPEG2 encoded files.<br><br>I was reluctant to upload it, as I wasn't sure about the status of the Smacker movies in the BS games, but since joostp got the OK from the Revolution guys, I guess we could add Smacker support to the videos of BS1/BS2?<br><br>Regards<br>Filippos Karapetis<br><br>> Date: Sun, 11 Jan 2009 19:18:52 +0100<br>> From: eriktorbjorn@telia.com<br>> To: scummvm-devel@lists.sourceforge.net<br>> Subject: Re: [Scummvm-devel] Dropping MPEG2 code?<br>> <br>> Max Horn wrote:<br>> <br>> > That's exactly how I would want it to be done :). Volunteers?<br>> <br>> The restructuring that was made when adding support for DXA cutscenes<br>> makes it quite straightforward to remove the MPEG support from Broken<br>> Sword 1/2:<br>> <br>> http://www.update.uu.se/~d91tan/ScummVM/mpeg2-removal.txt<br>> <br>> (That's a diff against current SVN.)<br>> <br>> Actually, for Broken Sword 1 you could probably go even further. There<br>> is support for some more advanced cutscene packs. I think the idea was<br>> to make language-independent cutscene packs, but I never added support<br>> for the video part of them to the DXA player, because I wasn't (and<br>> still isn't) convinced that they even exist.<br>> <br>> If you remove the remaining traces of them, starting with the<br>> cutscenePackVersion variable from the SystemVars struct, you would also<br>> lose the SplittedAudioStream class from animation.h, and most (all?) of<br>> credits.cpp.<br>> <br>> But maybe I've been wrong all along, and the advanced cutscene packs<br>> really do exist...?<br>> <br>> Torbjörn Andersson<br>> <br>> ------------------------------------------------------------------------------<br>> Check out the new SourceForge.net Marketplace.<br>> It is the best place to buy or sell services for<br>> just about anything Open Source.<br>> http://p.sf.net/sfu/Xq1LFB<br>> _______________________________________________<br>> Scummvm-devel mailing list<br>> Scummvm-devel@lists.sourceforge.net<br>> https://lists.sourceforge.net/lists/listinfo/scummvm-devel<br><br /><hr />Windows Live™ Hotmail®: Chat. Store. Share. Do more with mail. <a href='http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t1_hm_justgotbetter_explore_012009' target='_new'>Check it out.</a></body>
</html>