<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
</style>
</head>
<body class='hmmessage'>
Hi!<BR>
But this code is still left in VectorRenderer.h<BR>
<BR>
// To assure we have VECTOR_RENDERER_FORMAT specified when<BR>// DISABLE_FANCY_THEMES is defined, we error out elsewise<BR>#if defined(DISABLE_FANCY_THEMES) && !defined(VECTOR_RENDERER_FORMAT)<BR>#error "You need to specify a fixed overlay format via VECTOR_RENDERER_FORMAT"<BR>#endif<BR>
<BR>
I guess that should also be removed before we can remove VECTOR_RENDERER_FORMAT or?<BR>
<BR>
Cheers<BR>
Lars<BR> <BR>> Date: Mon, 16 Feb 2009 23:17:41 +0100<BR>> From: lordhoto@gmail.com<BR>> To: scummvm-devel@lists.sourceforge.net<BR>> Subject: [Scummvm-devel] PORTERS: Slight DISABLE_FANCY_THEMES handling change.<BR>> <BR>> Hi,<BR>> <BR>> First of all if your port does not define DISABLE_FANCY_THEMES this mail <BR>> is probably not really useful for you.<BR>> <BR>> You might have noticed that in trunk we switched our GUI renderer from <BR>> an pure template based approach, means taking an template parameter for <BR>> pixel format description, to an implementation, which takes a <BR>> Graphics::PixelFormat describing the pixel format as constructor <BR>> parameter. This allows us to support various different pixel formats <BR>> without any additionally generated code.<BR>> <BR>> This removes the need for VECTOR_RENDERER_FORMAT on platforms where <BR>> DISABLE_FANCY_THEMES is defined, since now for every system we can <BR>> safely use OSystem::getOverlayPixelFormat to pass it to the <BR>> VectorRenderer. Thus everyone defining VECTOR_RENDERER_FORMAT can now <BR>> safely remove it.<BR>> <BR>> // Johannes<BR>> <BR>> PS: If you want to check out the commit removing VECTOR_RENDERER_FORMAT <BR>> check diffs for r38381.<BR>> <BR>> ------------------------------------------------------------------------------<BR>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA<BR>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise<BR>> -Strategies to boost innovation and cut costs with open source participation<BR>> -Receive a $600 discount off the registration fee with the source code: SFAD<BR>> http://p.sf.net/sfu/XcvMzF8H<BR>> _______________________________________________<BR>> Scummvm-devel mailing list<BR>> Scummvm-devel@lists.sourceforge.net<BR>> https://lists.sourceforge.net/lists/listinfo/scummvm-devel<BR><br /><hr />Connect to the next generation of MSN Messenger <a href='http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source=wlmailtagline' target='_new'>Get it now! </a></body>
</html>