Hi!<br>Actually the isblank was a #define only active for WIN32 builds. But of course beeing able to remove dead code would be the best thing to do. :-)<br><br>And it seems like there are a couple of functions in that file that are not beeing used.<br>
Cheers<br>Lars<br><br><div class="gmail_quote">2009/2/16 Max Horn <span dir="ltr"><<a href="mailto:max@quendi.de" target="_blank">max@quendi.de</a>></span><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Am 16.02.2009 um 20:20 schrieb Max Horn:<div><div></div><div><br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Am 16.02.2009 um 19:40 schrieb <a href="mailto:anotherguest@users.sourceforge.net" target="_blank">anotherguest@users.sourceforge.net</a>:<br>
<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Revision: 38376<br>
<a href="http://scummvm.svn.sourceforge.net/scummvm/" target="_blank">http://scummvm.svn.sourceforge.net/scummvm/</a>?<br>
rev=38376&view=rev<br>
Author: anotherguest<br>
Date: 2009-02-16 18:40:36 +0000 (Mon, 16 Feb 2009)<br>
<br>
Log Message:<br>
-----------<br>
isblank is not available on all platforms. Needs to be handled in a<br>
different way.<br>
</blockquote>
<br>
Where is it not available? Symbian?<br>
<br>
We could simply provide<br>
<br>
#define scummvm_isblank(c) ((c) == ' ' || (c) == '\t' || (c) == '\n'<br>
|| (c) == '\r')<br>
<br>
in either a sci specific header, or if other stuff uses it, in<br>
scummsys.h.<br>
<br>
That would on the long run probably be more portable than trying to<br>
redefine isblank.<br>
</blockquote>
<br></div></div>
Looking at this again, my def of isblank was of course wrong, it should only check space and tab (and Lars actually provided code for that, whoops :-). Anyway, I wonder if isblank could be replaced by isspace there.<br>
<br>
Furthermore, I wonder about ./gfx/gfx_res_options.cpp -- for what is this code used? It also seems to contain some unused stuff, like gfx_update_conf() -- in fact, removing that function and then removing all the stuff that was only used by it, gets rid of all occurances of isblank(). Now I wonder whether it would be safe to just do that...<br>
<br>
<br>
Bye,<br><font color="#888888">
Max<br>
</font></blockquote></div><br>