<div class="gmail_quote">On Mon, Jul 6, 2009 at 12:41 PM, <span dir="ltr"><<a href="mailto:dkasak13@users.sourceforge.net">dkasak13@users.sourceforge.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
+ int _transparent = dst->getTransparentColour();</blockquote><div><br></div><div>two tiny comments applicable in general, should you agree.</div><div><br></div><div>1. it isn't a class member, so why do you start its name with an underscore?</div>
<div><br></div><div>2. it is a constant, so it would be self-documenting to label it such. if you say "const int transparent = ...;", then the compiler will make sure that won't get changed by mistake. now, this code is short and simple enough that it isn't a big deal, but in more complicated cases this helps.</div>
<div><br></div></div>-- <br>Robert Špalek <<a href="mailto:rspalek@gmail.com">rspalek@gmail.com</a>><br>