<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
</style>
</head>
<body class='hmmessage'>
There's also one more issue that is a bit unclear:<br><br>In switch statements, if braces are needed, should these be placed to the right of the case line?<br><br>i.e.<br><br>switch(foo) {<br>case 1: {<br> doSomething();<br>}<br>break;<br>case 2:<br>{<br> doSomethingElse();<br>}<br>break;<br>}<br><br>Should the braces look like case 1 or case 2?<br>I think that case 1 is more appropriate, but that is a bit unclear from the current wiki page<br><br>Regards<br>Filippos<br><br>> From: sev@scummvm.org<br>> Date: Wed, 16 Sep 2009 10:06:00 +0300<br>> To: whoozle@yandex.ru<br>> CC: scummvm-devel@lists.sourceforge.net; lordhoto@scummvm.org<br>> Subject: Re: [Scummvm-devel] Nested scopes in scummvm code.<br>> <br>> 2009/9/16 Vladimir Menshakov <whoozle@yandex.ru>:<br>> > 16.09.09, 02:41, "Johannes Schickel" <lordhoto@scummvm.org>:<br>> ><br>> >> megath@users.sourceforge.net wrote:<br>> >> > @@ -356,9 +356,13 @@<br>> >> > }<br>> >> > }<br>> >> ><br>> >> > - if (!hide_actor) {<br>> >> > + {<br>> >> > Surface *mark = actor_animation.currentFrame();<br>> >> ><br>> >> That's also violating our code formatting guidelines ;-). Maybe you<br>> >> should read all of them again.<br>> >> // Johannes<br>> ><br>> > Imagine that there's hidden "if (true) {" . Is there guidelines for nested scopes in scummvm code convention? Minor issue that has to be cleared.<br>> That is correct indentation. It would be nice if somebody update our<br>> conventions. In fact, it is widely used in switch() statements all<br>> around the code. That is (ignore the tabs):<br>> <br>> someCode();<br>> <br>> a += 1;<br>> <br>> {<br>> int foo;<br>> <br>> foo = 5;<br>> }<br>> <br>> someMoreCode();<br>> <br>> <br>> Eugene<br>> <br>> ------------------------------------------------------------------------------<br>> Come build with us! The BlackBerry® Developer Conference in SF, CA<br>> is the only developer event you need to attend this year. Jumpstart your<br>> developing skills, take BlackBerry mobile applications to market and stay <br>> ahead of the curve. Join us from November 9-12, 2009. Register now!<br>> http://p.sf.net/sfu/devconf<br>> _______________________________________________<br>> Scummvm-devel mailing list<br>> Scummvm-devel@lists.sourceforge.net<br>> https://lists.sourceforge.net/lists/listinfo/scummvm-devel<br><br /><hr />Hotmail: Powerful Free email with security by Microsoft. <a href='http://clk.atdmt.com/GBL/go/171222986/direct/01/' target='_new'>Get it now.</a></body>
</html>