<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 2009-11-10, at 14:52, Pawel Kolodziejski wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On 2009-11-09, at 23:15, Max Horn wrote:<br><br><blockquote type="cite"><br></blockquote><blockquote type="cite">Am 09.11.2009 um 22:35 schrieb Max Horn:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Anfang der weitergeleiteten E-Mail:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Von: Pawel Kolodziejski <<a href="mailto:aquadran@xtr.net.pl">aquadran@xtr.net.pl</a>><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Datum: 9. November 2009 17:21:14 MEZ<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">An: Max Horn <<a href="mailto:max@quendi.de">max@quendi.de</a>><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Betreff: Re: [Scummvm-cvs-logs] <a href="http://SF.net">SF.net</a> SVN: scummvm:[45775] scummvm/<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">trunk/backends/platform<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">On 2009-11-09, at 15:58, Max Horn wrote:<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Am 09.11.2009 um 15:29 schrieb <a href="mailto:aquadran@users.sourceforge.net">aquadran@users.sourceforge.net</a>:<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Revision: 45775<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"> <a href="http://scummvm.svn.sourceforge.net/scummvm/?">http://scummvm.svn.sourceforge.net/scummvm/?</a><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">rev=45775&view=rev<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Author: aquadran<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Date: 2009-11-09 14:29:53 +0000 (Mon, 09 Nov 2009)<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Log Message:<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">-----------<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">added samsung tv backend<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Added Paths:<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">-----------<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/events.cpp<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/graphics.cpp<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/hardwarekeys.cpp<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/main.cpp<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/module.mk<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/sdl.cpp<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">scummvm/trunk/backends/platform/samsungtv/sdl.h<br></blockquote></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">This backend seems to duplicate most of the SDL backend -- very<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">ugly. Any particular reason it couldn't subclass the SDL backend,<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">instead of duplicating all that code?<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">It's in progress, so subclass not yet, and there are small changes<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">which does not allow much of methods as subclass. Also I don't want<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">put hacks into main sdl code.<br></blockquote></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Well, this new backend is still 95% identical to the SDL backend. I<br></blockquote><blockquote type="cite">find this rather aggravating :/. As we make changes to the SDL<br></blockquote><blockquote type="cite">backend, they will start to deviate further, though. I am scared by<br></blockquote><blockquote type="cite">the prospect of having this SDL backend clone in there and starting to<br></blockquote><blockquote type="cite">bitrot, just like ther old sdl-opengl backend. The SDL backend already<br></blockquote><blockquote type="cite">contains tons of #ifdefs etc., so on the one hand it is not nice to<br></blockquote><blockquote type="cite">had more, but on the other hand, it's not really making things <br></blockquote><blockquote type="cite">worse...<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">But looking at your changes specifically, it seems to me that it would<br></blockquote><blockquote type="cite">still be far preferable and indeed quite doable to realize this as a<br></blockquote><blockquote type="cite">subclassed backend, by turning only a few key methods into virtual<br></blockquote><blockquote type="cite">ones, resp. factoring out some code that you have to implement<br></blockquote><blockquote type="cite">differently for your backend into new virtual methods. This will lead<br></blockquote><blockquote type="cite">to much better code on the long run.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Such a refactoring would be a nice small step towards refactoring the<br></blockquote><blockquote type="cite">SDL backend to make life better for backends derived from it, such as<br></blockquote><blockquote type="cite">the WinCE & Symbian backends.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Disregarding the issues I have with the actual code, there is one<br></blockquote><blockquote type="cite">other thing: I really really *really* dislike learning about a new<br></blockquote><blockquote type="cite">backend being added via the commit message. This is just as bad as if<br></blockquote><blockquote type="cite">it happens for an engine. This is really not good practice. In the<br></blockquote><blockquote type="cite">future, I expect everybody who adds major new components like backends<br></blockquote><blockquote type="cite">or engines to announce these *beforehand* on -devel, and wait for<br></blockquote><blockquote type="cite">approval. Getting approval from either me or Eugene alone is not<br></blockquote><blockquote type="cite">enough, this must go over -devel. Anyway, it's too late for that now;<br></blockquote><blockquote type="cite">but please at the very least, write an email to -devel now which<br></blockquote><blockquote type="cite">explains your new backend, what it is good for, and what your plans<br></blockquote><blockquote type="cite">are to address the concerns I voiced above.<br></blockquote><br><br>There are 3 things which are came into my mind right now.<br><br>- First take advantage of hardware 2D blitting.<br>To allow use it, destination surface must be HWSURFACE.<br>Source could be SW or HW.<br>It's unknown to me what are limitations. What pixel format it will work,<br>is it only 32 bit format? Is is capable pixel format conversion ?<br>How fast it is ?<br>So I need more test to figure out that things.<br><br></div></blockquote><div><br></div><div><br></div><div>After testing all combinations of accessing screen and surface buffers and blitting,</div><div>I found out accessing HW_SURFACE has same time as for SW_SURFACE.</div><div>Doesn't matter if it's screen or surface. Hardware blitting take place only</div><div>if both surfaces are hardware type. However it force blit only in 32 bit.</div><div>So in 16 hardware take place, but result is not proper like it ignore 16 bit and </div><div>see as 32 bit.</div><div>Anyway it this case I can't take any advantage of this.</div><div><br></div><br><blockquote type="cite"><div>- Remote controller does not able double keypress.<br>Each keypress has some timeout delay until it send key up event.<br>So it's very difficult to do double click used in gui browser.<br>I wonder if it's possible emulate keypress by mapping to some<br>key.<br><br></div></blockquote><div><br></div><div>Due really limited available keys on remote controller I set fixed mapping to</div><div>some keys for basic functionality. For full functionality port need support</div><div>mouse and keyboard.</div><br><blockquote type="cite"><div>- Currently there is issues with positioning mouse cursor in game <br>engine.<br>Tested it with Tentacle. Mouse seems draw properly but game get wrong<br>coordinates. I'm a bit surprised, I did change thing only to SDL_Wrap <br>thing,<br>but maybe issue is here.<br><br></div></blockquote><div><br></div><div>This bug is fixed now.</div><div><br></div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font><br></div></blockquote><div><br></div><div><br></div><div>I'm currently planning fix crash comi , zak fmtowns on startup, rest scumm games runs fine.</div><br><blockquote type="cite"><div><br><br><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Bye,<br></blockquote><blockquote type="cite">Max<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">------------------------------------------------------------------------------<br></blockquote><blockquote type="cite">Let Crystal Reports handle the reporting - Free Crystal Reports 2008 <br></blockquote><blockquote type="cite">30-Day<br></blockquote><blockquote type="cite">trial. Simplify your report design, integration and deployment - and <br></blockquote><blockquote type="cite">focus on<br></blockquote><blockquote type="cite">what you do best, core application coding. Discover what's new with<br></blockquote><blockquote type="cite">Crystal Reports now. <a href="http://p.sf.net/sfu/bobj-july">http://p.sf.net/sfu/bobj-july</a><br></blockquote><blockquote type="cite">_______________________________________________<br></blockquote><blockquote type="cite">Scummvm-devel mailing list<br></blockquote><blockquote type="cite"><a href="mailto:Scummvm-devel@lists.sourceforge.net">Scummvm-devel@lists.sourceforge.net</a><br></blockquote><blockquote type="cite"><a href="https://lists.sourceforge.net/lists/listinfo/scummvm-devel">https://lists.sourceforge.net/lists/listinfo/scummvm-devel</a><br></blockquote><blockquote type="cite"><br></blockquote><br><br>------------------------------------------------------------------------------<br>Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day <br>trial. Simplify your report design, integration and deployment - and focus on <br>what you do best, core application coding. Discover what's new with<br>Crystal Reports now. <a href="http://p.sf.net/sfu/bobj-july">http://p.sf.net/sfu/bobj-july</a><br>_______________________________________________<br>Scummvm-devel mailing list<br><a href="mailto:Scummvm-devel@lists.sourceforge.net">Scummvm-devel@lists.sourceforge.net</a><br>https://lists.sourceforge.net/lists/listinfo/scummvm-devel<br><br></div></blockquote></div><br></body></html>