<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I tested several tools today (GUI and CLI) with a version I compiled yesterday evening.<div><br></div><div>First the good news: extract_scumm_mac works like a charm with the GUI tool. I tried all the mac games I have (DOTT, FT and Sam&Max), letting the GUi auto-detect the tool or selecting it manually, with input and/or output directory names that contain spaces and special characters. Everything worked.</div><div><br></div><div>However the CLI for extract_scumm_mac does not work (the only way to make it work is to create a out/ directory in the current directory). See bugs:</div><div>#2905462: cannot use -o or --output flags with tools_cli</div><div>#2905466: issue with extract_scumm_mac default output directory</div><div><br></div><div><br></div><div>Another nearly good news: compress_scumm_sou works (more or less). I had one issues with it:</div><div>#<span class="Apple-style-span" style="color: rgb(85, 85, 85); font-family: Arial; font-size: 12px; ">2905473: <span class="Apple-style-span" style="color: rgb(0, 0, 0); ">cannot use lame with compress_scumm_sou GUI (it works fine with the CLI)</span></span></div><div><font class="Apple-style-span" face="Arial">I also add the same problem as with extract_scumm_mac when trying to use -o or --output flag with the CLI.</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">Otherwise vorbis and flac work work well with both CLI and GUI. However in the GUI the temporary files are always named tempfile.mp3, and it looks strange to see several messages with "tempname.mp3" when you selected vorbis (in the CLI the temporary files are named tempfile.ogg when using vorbis).</font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial"><br></font></div><div><font class="Apple-style-span" face="Arial">A really bad news is that I couldn't make compress_scumm_san and compress_scumm_bun work. I get errors with both the GUI and the CLI.</font></div><div><font class="Apple-style-span" face="Arial">#<span class="Apple-style-span" style="font-size: 12px; ">2905479: extract_scumm_san and extract_scumm_bun do not work</span></font></div><div><div><br></div><div><br></div><div>One more minor thing: the GUI is using the old ScummVM logo and this should be updated.</div><div><br></div><div><br></div><div>I also have a few suggestions to improve the GUI:</div><div>* Would it be possible to display a progress bar for extract_scumm_mac and compress_scumm_* (e.g. % of the input file size that has been processed)?</div><div><br></div><div>* Could the tool remember the user last <span class="Apple-style-span" style="font-size: 12px; ">choice for the Open output folder checkbox on the last page?</span></div><div><br></div><div>* <span class="Apple-style-span" style="font-size: 12px; ">Cancel after running the tools does not make sense as it does nothing. I think that the button should be disabled after running the tool and at least on the last page (or maybe it should delete the output of the tool).</span></div><div><br></div><div>* <span class="Apple-style-span" style="font-size: 12px; ">Select input files: we can select several files in the file chooser but then only one is listed in the text field of the Tools GUI. Maybe the file chooser should not accept selection of multiple files.</span></div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: 12.0px Helvetica">* On the last page it would be nice to have an option to extract or compress other files (i.e. go back on the first page instead of closing the application).</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><br></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: 12.0px Helvetica">* It is not evident to know when the tools have finished to process the files in the GUI. This is I think for two reasons:</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: 12.0px Helvetica">1) It is still displaying "Processing data..." above the scroll view after it has finished</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: 12.0px Helvetica">2) The scrollview with the output does not always automatically scroll to the end (for me it almost never does) which means the "Tool finished without errors!" message is not visible if the user does not scroll manually.</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; "><font face="Helvetica" size="3" style="font: 12.0px Helvetica">I think the "Processing data..." message should be changed or removed at the end of the processing. Also maybe the "Tools finished without erors!" message could be shown outside (e.g. below) the scroll view. It could even use a different colors (e.g. green if no errors, red if there were errors).</font></div><div><br></div><div>* Lastly, you should probably remove the developer note from the GUI in the page to select the input file.</div><div><br></div><div><br></div><div>Thierry</div></div></div></div></body></html>