Hello<div><br></div><div>I'm the one who wrote the PNG decoder. The situation is as follows:</div><div>Broken Sword 2.5 requires both a PNG decoder (for its images) and a PNG encoder (for the thumbnails in its saved games).</div>
<div>Right now, the thumbnails in the saved games are broken (they always were broken), it's something I haven't looked into yet.</div><div><br></div><div>The PNG decoder works almost flawlessly.</div><div>I haven't written a PNG encoder, which is where libpng is still needed.</div>
<div><br></div><div>The original plan was to remove compatibility with the saved games that the original engine creates (as they are version</div><div>specific anyway), starting with the thumbnail support. If you don't mind dropping savegame compatibility with the original</div>
<div>engine, we can remove the libpng dependency.</div><div><br></div><div>So... the available options are:</div><div>- Keep savegame compatibility with game version 1.0, keep libpng, remove our own PNG decoder (which works, as I said) and</div>
<div>attempt to find the problem with the savegame thumbnails</div><div>- Drop savegame compatibility, use our own thumbnail code, remove libpng and use our own PNG decoder</div><div><br></div><div>What should we do?</div>
<div><br></div><div>Regards</div><div>Filippos</div><div><br></div><div><br><div class="gmail_quote">On Fri, Apr 29, 2011 at 1:49 PM, Max Horn <span dir="ltr"><<a href="mailto:max@quendi.de">max@quendi.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Just did a configure run with a cross compiler for which I had no libpng, and got this:<br>
<br>
Checking for PNG >= 1.2.8... no<br>
...disabling Broken Sword 2.5 engine. PNG is required<br>
<br>
Now I am confused: I thought folks added a custom png decoder to graphics/ so that we don't need libpng anymore. So, do we really still need to disable BS2.5 just because libpng is present? And if libpng is present, do we disable graphics/png.* ?<br>
<br>
It would be nice if somebody could clarify this. My take is this:<br>
If graphics/png.* cannot substitute libpng good enough to be used as a replacement in BS2.5, I don't see why we have it at all (unless somebody is actively working on fixing it).<br>
<br>
If it can act as a substitute for libpng, then<br>
1) we should not disable BS2.5 in configure just because libpng is missing,<br>
2) maybe we should compiler *either* with libpng, *or* with our custom png decoder. Having both present simultaneously seems like wasting binary size for nothing.<br>
<br>
But maybe I am missing something here. So once more, I'd appreciate if somebody (the people who added the png decoder in the first place, maybe?) could take a look at this and clarify this / fix it as appropriate :).<br>
<br>
Thanks & Cheers,<br>
Max<br>
<br>
<br>
------------------------------------------------------------------------------<br>
WhatsUp Gold - Download Free Network Management Software<br>
The most intuitive, comprehensive, and cost-effective network<br>
management toolset available today. Delivers lowest initial<br>
acquisition cost and overall TCO of any competing solution.<br>
<a href="http://p.sf.net/sfu/whatsupgold-sd" target="_blank">http://p.sf.net/sfu/whatsupgold-sd</a><br>
_______________________________________________<br>
Scummvm-devel mailing list<br>
<a href="mailto:Scummvm-devel@lists.sourceforge.net">Scummvm-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/scummvm-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/scummvm-devel</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>"Experience is the name every one gives to their mistakes" - Oscar Wilde <br>
</div>