<div class="gmail_quote">On Mon, Oct 24, 2011 at 8:06 AM, Tarek Soliman <span dir="ltr"><<a href="mailto:tarek-spam@zeusmail.bounceme.net">tarek-spam@zeusmail.bounceme.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<a href="https://github.com/tsoliman/scummvm/commits/scumm-speech-detection2" target="_blank">https://github.com/tsoliman/scummvm/commits/scumm-speech-detection2</a><br>
This sets a null pointer on gui options and works only because of the current detection table entries not containing anything critical.<br>
It works fine because the guioptions are being used only after being wrapped into a Common::String which is well guarded against null pointers: it treats it as an empty string.<br>
This works _now_ but won't work if the detection entries change which is going to happen.<br></blockquote></div><br>Well, you could use "" or GUIO1(GUIO_NONE) instead, which should work just fine. In fact, I think this patch (with the suggested change) looks like the cleanest approach (and it's not a hack)<br>
<br>Regards<br>Filippos<br clear="all"><br>-- <br>"Experience is the name every one gives to their mistakes" - Oscar Wilde <br>