<div dir="ltr">Hi guys,<div><br></div><div style>I realized that Coverity offers free access to their excellent tools to Open Source projects.</div><div style><br></div><div style>Thus I submitted ScummVM to Coverity (Mac build), and results of the analysis are available.</div>
<div style><br></div><div style>Please get registered here: <a href="http://scan.coverity.com/user_register.html">http://scan.coverity.com/user_register.html</a> (email me with the password request).</div><div style><br>
</div>
<div style>In essence, the results are presented in a table below. Quick inspection showed that many of the findings are very true. However I understand that in some cases the game data will never exceed some threshold, still there are no sanity checks in many places, and Coverity found them.</div>
<div style><br></div><div style>I plan to build the solution from time to time, the platform over there allows to mark issues as false positives or fixed and then track their history.</div><div style><br></div><div style>
So please assign the findings to yourself when you fix them, or mark as confirmed, so other will not waste their time on analysis and we can process the output step by step.</div><div style><br></div><div style>Here is the result summary:</div>
<div style><br></div><div style><div>Defect occurrences found : 2143 Total</div><div> 4 ARRAY_VS_SINGLETON</div><div> 1 ASSERT_SIDE_EFFECT</div><div> 4 BAD_COMPARE</div><div> 1 BAD_FREE</div><div> 1 BAD_OVERRIDE</div><div>
43 CHECKED_RETURN</div><div> 6 CONSTANT_EXPRESSION_RESULT</div><div> 17 COPY_PASTE_ERROR</div><div> 3 CTOR_DTOR_LEAK</div><div> 91 DEADCODE</div><div> 3 DELETE_ARRAY</div><div> 1 EVALUATION_ORDER</div><div> 131 FORWARD_NULL</div>
<div> 65 MISSING_BREAK</div><div> 21 NEGATIVE_RETURNS</div><div> 8 NO_EFFECT</div><div> 26 NULL_RETURNS</div><div> 153 OVERRUN</div><div> 7 PASS_BY_VALUE</div><div> 63 RESOURCE_LEAK</div><div> 1 RETURN_LOCAL</div><div> 21 REVERSE_INULL</div>
<div> 13 REVERSE_NEGATIVE</div><div> 225 SIGN_EXTENSION</div><div> 2 SIZECHECK</div><div> 1 SIZEOF_MISMATCH</div><div> 72 UNINIT</div><div> 989 UNINIT_CTOR</div><div> 28 UNREACHABLE</div><div> 128 UNUSED_VALUE</div><div>
9 USE_AFTER_FREE</div>
<div> 5 VARARGS</div><div><br></div><div><br></div><div style>Eugene</div><div style><br></div></div></div>