<div dir="ltr">That's great! Thank you!<div><br></div><div><br></div><div>Eugene</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 6 July 2013 07:21, D G Turner <span dir="ltr"><<a href="mailto:d.g.turner@ntlworld.com" target="_blank">d.g.turner@ntlworld.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eugene,<br>
I have looked at the reason for the "make test" failure since the<br>
Event Recorder was merged. This is due to the new and undesired<br>
dependency between the common and GUI code introduced by this.<br>
<br>
Though removing all of this requirement is a more complex design<br>
question, I have worked out that it is possible to restore the<br>
tests functionality for now.<br>
<br>
This will require the attached patch to common/system.cpp to be<br>
applied. It adds #ifdef ENABLE_EVENTRECORDER guards which are<br>
currently not present in this file, but are very similar to those<br>
present in various other files including base/main.cpp.<br>
<br>
This will then truly remove the dependency when the event recorder<br>
is disabled, rather than leaving some linkages in system.cpp.<br>
<br>
I can then fix the tests on buildbot by adding "--disable-<br>
eventrecorder" to the configure options passed to the debian-x86<br>
native build.<br>
<br>
As this is a fairly trivial patch, I didn't think it warranted a<br>
Pull Request, but I didn't want to cause another argument with the<br>
Core Team if I applied this fix directly, so am sending it to the<br>
list for comment and review.<br>
<br>
I am aware that this could be considered a "hack", though my view is<br>
that those guards should be present in that file in any case and this<br>
solution has the advantage of restoring the tests functionality now,<br>
rather that leaving these broken (which would leave the common code<br>
open to developing bugs which are not picked up until much later).<br>
<br>
Any views on this? If there are no objections, I will apply this<br>
patch in the next few days and make the requisite change to buildbot.<br>
Thanks,<br>
David Turner<br>
</blockquote></div><br></div>