<HTML><BODY>Loks like it always int. In some cases signed.<br><br><br>Панядзелак, 16 снежня 2013, 18:27 UTC ад Willem Jan Palenstijn <wjp@usecode.org>:<br>
<blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div id="style_13872184820000000383" class="mr_read__body">
<base target="_self" href="https://e.mail.ru/">
<div id="style_13872184820000000383_BODY"><br>
<br>
On Mon, Dec 16, 2013 at 10:23:38PM +0400, Федор wrote:<br>
> Look at <a href="http://svn.xiph.org/trunk/ogg/include/ogg/os_types.h" target="_blank">http://svn.xiph.org/trunk/ogg/include/ogg/os_types.h</a> : ogg_int32_t in known for me cases always int. <br>
<br>
Hi,<br>
<br>
I'm confused. So you're now confirming that ogg_int32_t is always a signed int?<br>
<br>
-Willem Jan<br>
<br>
<br>
<br>
<br>
<br>
> <br>
> Here compiler try set second parameter in vorbis_synthesis_pcmout() with float instead int. This cause compiler error:<br>
> <br>
> /Symbian/Projects/SDL/scummvm/video/theora_decoder.cpp: In member function 'bool Video::TheoraDecoder::VorbisAudioTrack::decodeSamples()':<br>
> /Symbian/Projects/SDL/scummvm/video/theora_decoder.cpp:363: error: 'signed' or 'unsigned' invalid for 'pcm'<br>
> /Symbian/Projects/SDL/scummvm/video/theora_decoder.cpp:366: error: cannot convert 'float***' to 'ogg_int32_t***' for argument '2' to 'int vorbis_synthesis_pcmout(vorbis_dsp_state*, ogg_int32_t***)<br>
> <br>
> Панядзелак, 16 снежня 2013, 17:10 UTC ад Willem Jan Palenstijn <<a href="sentmsg?compose&To=wjp@usecode.org">wjp@usecode.org</a>>:<br>
> >On Mon, Dec 16, 2013 at 03:28:31AM +0400, Федор wrote:<br>
> >> Hi! Are you planned add support Tremor/Tremolo to builtin theora player?<br>
> >> I look at theora_decoder.h and theora_decoder.cpp. To make it compatible with<br>
> >> Tremor/Tremolo necessary make this steps :<br>
> >> 1) in theora_decoder.cpp in line 363 pointer **pcm declared as unsigned float<br>
> >> but in ivorbiscodec.h it has ogg_int32_t type<br>
> ><br>
> ><br>
> >> This type may be signed or not at various OS. You can declare it as ogg_int32_t<br>
> ><br>
> >Really? That would be surprising, especially since there's also an ogg_uint32_t.<br>
> >Do you have a reference for this claim?<br>
> ><br>
> >-Willem Jan<br>
> ><br>
> >------------------------------------------------------------------------------<br>
> <br>
> <br>
> С уважением, Федор Стрижнёв.<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br>С уважением, Федор Стрижнёв.<br></BODY></HTML>