<div dir="ltr">So, should the Steam versions be included in the upcoming 1.7.0 release?<div><br></div><div>I am thinking of cherry-picking all the relevant commits from master into the 1-7.0 branch. I'm talking about the 9 commits from LordHoto and me since the 3rd of July, 2014:</div>
<div><a href="https://github.com/scummvm/scummvm/commits/master/engines/scumm">https://github.com/scummvm/scummvm/commits/master/engines/scumm</a><br></div><div><br></div><div>Are you all OK with these? If there's no reply by tomorrow evening, I'll include these in the 1.7.0 branch, since there are very few days left until feature freeze...</div>
<div><br></div><div>Regards</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jul 5, 2014 at 4:14 PM, Filippos Karapetis <span dir="ltr"><<a href="mailto:bluegr@gmail.com" target="_blank">bluegr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The pull request has now been merged to master, and all the different versions are supported (both the Windows and the Macintosh ones).<div>
<br></div><div>This could also be merged to the 1.7.0 branch, as the games are essentially the same DOS versions, with the only difference being the way the index file is accessed, and the audio format used for the Steam version of Loom.</div>
<div><br></div><div>If anyone is interested in these versions, they can be bought off Steam as part of the "LucasArts Adventure Pack" for 9 EUR:</div><div><a href="http://store.steampowered.com/sub/2102/" target="_blank">http://store.steampowered.com/sub/2102/</a><br>
</div><div><br></div><div>Depending on your Steam client, you'll get either the Windows or Mac executables (with the index file embedded in them). The other game data files are the same as the DOS versions.</div><div>
<br></div><div>Regards</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Jun 22, 2014 at 4:22 PM, Filippos Karapetis <span dir="ltr"><<a href="mailto:bluegr@gmail.com" target="_blank">bluegr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I've made a pull request for this here:<div><a href="https://github.com/scummvm/scummvm/pull/470" target="_blank">https://github.com/scummvm/scummvm/pull/470</a><br>
</div><div class="gmail_extra"><br></div><div class="gmail_extra">
The changes are based on Ben Castricum's work, but I've opted for a less invasive patch - all the file handling is done at the file handle level, which makes the changes more self-contained rather than scattered in different parts of the engine.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">The pull request doesn't handle CDDA.SOU yet - I too agree that this shouldn't be handled outside of the SCUMM engine. If people feel that this should be handled in the SCUMM engine (which is the best and cleanest way, IMHO), then this part can be rewritten into a separate commit.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Regards</div><span><font color="#888888"><div class="gmail_extra">Filippos</div><div class="gmail_extra"><br></div></font></span><div class="gmail_extra">
<div><div><br><div class="gmail_quote">On Thu, Jun 12, 2014 at 11:07 PM, Matthew Hoops <span dir="ltr"><<a href="mailto:clone2727@gmail.com" target="_blank">clone2727@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">It's not a pull request, but I'll comment on it here anyway: Inserting CDDA.SOU-related outside of SCUMM is unacceptable.</p>
<p dir="ltr">Matt</p><div><div>
<div class="gmail_quote">On Jun 12, 2014 3:45 PM, "Ben Castricum" <<a href="mailto:scummvm@bencastricum.nl" target="_blank">scummvm@bencastricum.nl</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 4-6-2014 16:42, Eugene Sandulenko wrote:<br>
> Okay, in this case majority wins, please submit a pull request.<br>
<br>
In case anyone is going to develop a steam support patch based on that<br>
old patch I once wrote for v1.4, I updated it to the current master<br>
branch. I playtested it a bit and it still seems to work.<br>
<br>
<a href="https://github.com/BenCastricum/scummvm/tree/steam" target="_blank">https://github.com/BenCastricum/scummvm/tree/steam</a><br>
<br>
Cheers,<br>
Ben<br>
<br>
------------------------------------------------------------------------------<br>
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions<br>
Find What Matters Most in Your Big Data with HPCC Systems<br>
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.<br>
Leverages Graph Analysis for Fast Processing & Easy Data Exploration<br>
<a href="http://p.sf.net/sfu/hpccsystems" target="_blank">http://p.sf.net/sfu/hpccsystems</a><br>
_______________________________________________<br>
Scummvm-devel mailing list<br>
<a href="mailto:Scummvm-devel@lists.sourceforge.net" target="_blank">Scummvm-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/scummvm-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/scummvm-devel</a><br>
</blockquote></div>
</div></div><br>------------------------------------------------------------------------------<br>
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions<br>
Find What Matters Most in Your Big Data with HPCC Systems<br>
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.<br>
Leverages Graph Analysis for Fast Processing & Easy Data Exploration<br>
<a href="http://p.sf.net/sfu/hpccsystems" target="_blank">http://p.sf.net/sfu/hpccsystems</a><br>_______________________________________________<br>
Scummvm-devel mailing list<br>
<a href="mailto:Scummvm-devel@lists.sourceforge.net" target="_blank">Scummvm-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/scummvm-devel" target="_blank">https://lists.sourceforge.net/lists/listinfo/scummvm-devel</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div></div></div><div>-- <br>"Experience is the name every one gives to their mistakes" - Oscar Wilde
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>"Experience is the name every one gives to their mistakes" - Oscar Wilde
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>"Experience is the name every one gives to their mistakes" - Oscar Wilde
</div>